Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 1154703005: [DevTools] Added window listeners to EventListenersSidebar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 1154703005: [DevTools] Added window listeners to EventListenersSidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@extract-event-listeners-tree-outline

Patch Set: Test fixed Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/components/EventListenersView.js ('K') | « Source/devtools/front_end/components/EventListenersView.js ('k') | Source/devtools/front_end/elements/EventListenersSidebarPane.js » ('j') | Source/devtools/front_end/sdk/DOMModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/Source/devtools/front_end/components/ObjectPropertiesSection.js b/Source/devtools/front_end/components/ObjectPropertiesSection.js

index 9ffc15ca93c4c4c6ade75ed2c9df80ad8e260339..99c95524c09587edbdd0f6e40ceb4d280c1ea7c1 100644

--- a/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -1147,6 +1147,7 @@ WebInspector.ObjectPropertiesSection.createValueElement = function(value, wasThr

if (type === "object" && subtype === "node" && description) {

WebInspector.DOMPresentationUtils.createSpansForNodeTitle(valueElement, description);

+ valueElement.addEventListener("click", WebInspector.Revealer.reveal.bind(WebInspector.Revealer, value, undefined), false);

pfeldman 2015/05/25 16:25:16 Make sure you consume the click.

kozy 2015/05/25 18:03:30 Done.

valueElement.addEventListener("mousemove", mouseMove, false);

valueElement.addEventListener("mouseleave", mouseLeave, false);

} else {