Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1154703005: [DevTools] Added window listeners to EventListenersSidebar (Closed)

Created:
5 years, 7 months ago by kozy
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@extract-event-listeners-tree-outline
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Added window listeners to EventListenersSidebar If filter is setted to "All Nodes" then listeners from curent execution context's window will be shown in Event Listeners Sidebar in Elements Panel. BUG=469159 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195875

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 14

Patch Set 3 : #

Patch Set 4 : Test fixed #

Total comments: 8

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : Test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -108 lines) Patch
M LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/domdebugger/domdebugger-getEventListeners-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/event-listener-sidebar-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/EventListenersView.js View 1 2 3 4 6 chunks +20 lines, -74 lines 0 comments Download
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/EventListenersSidebarPane.js View 1 2 2 chunks +46 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/RemoteObject.js View 1 2 3 4 2 chunks +33 lines, -24 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
kozy
ptal.
5 years, 7 months ago (2015-05-22 10:52:48 UTC) #2
pfeldman
https://codereview.chromium.org/1154703005/diff/20001/Source/devtools/front_end/components/EventListenersView.js File Source/devtools/front_end/components/EventListenersView.js (right): https://codereview.chromium.org/1154703005/diff/20001/Source/devtools/front_end/components/EventListenersView.js#newcode75 Source/devtools/front_end/components/EventListenersView.js:75: * @return {!Promise} .<undefined> https://codereview.chromium.org/1154703005/diff/20001/Source/devtools/front_end/components/EventListenersView.js#newcode96 Source/devtools/front_end/components/EventListenersView.js:96: object.getEventListeners(listenersCallback.bind(this)); Lets convert ...
5 years, 7 months ago (2015-05-25 13:18:43 UTC) #3
kozy
All done. Please take a look! https://codereview.chromium.org/1154703005/diff/20001/Source/devtools/front_end/components/EventListenersView.js File Source/devtools/front_end/components/EventListenersView.js (right): https://codereview.chromium.org/1154703005/diff/20001/Source/devtools/front_end/components/EventListenersView.js#newcode75 Source/devtools/front_end/components/EventListenersView.js:75: * @return {!Promise} ...
5 years, 7 months ago (2015-05-25 14:55:24 UTC) #5
pfeldman
https://codereview.chromium.org/1154703005/diff/80001/Source/devtools/front_end/components/EventListenersView.js File Source/devtools/front_end/components/EventListenersView.js (right): https://codereview.chromium.org/1154703005/diff/80001/Source/devtools/front_end/components/EventListenersView.js#newcode63 Source/devtools/front_end/components/EventListenersView.js:63: return object.getEventListeners().then(this._addObjectEventListeners.bind(this, object)); eventListeners() https://codereview.chromium.org/1154703005/diff/80001/Source/devtools/front_end/components/ObjectPropertiesSection.js File Source/devtools/front_end/components/ObjectPropertiesSection.js (right): https://codereview.chromium.org/1154703005/diff/80001/Source/devtools/front_end/components/ObjectPropertiesSection.js#newcode1150 ...
5 years, 7 months ago (2015-05-25 16:25:17 UTC) #6
pfeldman
lgtm
5 years, 7 months ago (2015-05-25 16:29:01 UTC) #7
kozy
https://codereview.chromium.org/1154703005/diff/80001/Source/devtools/front_end/components/EventListenersView.js File Source/devtools/front_end/components/EventListenersView.js (right): https://codereview.chromium.org/1154703005/diff/80001/Source/devtools/front_end/components/EventListenersView.js#newcode63 Source/devtools/front_end/components/EventListenersView.js:63: return object.getEventListeners().then(this._addObjectEventListeners.bind(this, object)); On 2015/05/25 16:25:16, pfeldman wrote: > ...
5 years, 7 months ago (2015-05-25 18:03:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154703005/100001
5 years, 7 months ago (2015-05-25 18:03:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154703005/120001
5 years, 7 months ago (2015-05-25 18:12:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/63075)
5 years, 7 months ago (2015-05-25 20:28:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154703005/140001
5 years, 7 months ago (2015-05-25 20:33:40 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 21:45:45 UTC) #21
Message was sent while issue was closed. 
Committed patchset #7 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195875

Powered by Google App Engine
This is Rietveld 408576698