Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 1154703005: [DevTools] Added window listeners to EventListenersSidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@extract-event-listeners-tree-outline
Patch Set: Test fixed Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 parentElement.classList.add("hbox"); 1140 parentElement.classList.add("hbox");
1141 } 1141 }
1142 1142
1143 if (wasThrown) 1143 if (wasThrown)
1144 valueElement.classList.add("error"); 1144 valueElement.classList.add("error");
1145 if (subtype || type) 1145 if (subtype || type)
1146 valueElement.classList.add("object-value-" + (subtype || type)); 1146 valueElement.classList.add("object-value-" + (subtype || type));
1147 1147
1148 if (type === "object" && subtype === "node" && description) { 1148 if (type === "object" && subtype === "node" && description) {
1149 WebInspector.DOMPresentationUtils.createSpansForNodeTitle(valueElement, description); 1149 WebInspector.DOMPresentationUtils.createSpansForNodeTitle(valueElement, description);
1150 valueElement.addEventListener("click", WebInspector.Revealer.reveal.bind (WebInspector.Revealer, value, undefined), false);
pfeldman 2015/05/25 16:25:16 Make sure you consume the click.
kozy 2015/05/25 18:03:30 Done.
1150 valueElement.addEventListener("mousemove", mouseMove, false); 1151 valueElement.addEventListener("mousemove", mouseMove, false);
1151 valueElement.addEventListener("mouseleave", mouseLeave, false); 1152 valueElement.addEventListener("mouseleave", mouseLeave, false);
1152 } else { 1153 } else {
1153 valueElement.title = description || ""; 1154 valueElement.title = description || "";
1154 } 1155 }
1155 1156
1156 function mouseMove() 1157 function mouseMove()
1157 { 1158 {
1158 WebInspector.DOMModel.highlightObjectAsDOMNode(value); 1159 WebInspector.DOMModel.highlightObjectAsDOMNode(value);
1159 } 1160 }
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
1227 return; 1228 return;
1228 if (token === "(") { 1229 if (token === "(") {
1229 params = []; 1230 params = [];
1230 return; 1231 return;
1231 } 1232 }
1232 if (params && tokenType === "js-def") 1233 if (params && tokenType === "js-def")
1233 params.push(token); 1234 params.push(token);
1234 } 1235 }
1235 } 1236 }
1236 } 1237 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698