Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1154623008: Fix the secure proxy check state displayed on net-internals#bandwidth. (Closed)

Created:
5 years, 6 months ago by jeremyim
Modified:
5 years, 6 months ago
Reviewers:
sclittle
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the secure proxy check state displayed on net-internals#bandwidth. In the Data Reduction Proxy event store, if the secure proxy check failed due to an HTTP response status failure, or a content failure (i.e. the check returned text that wasn't "OK"), the net-internals#bandwidth page would indicate that the secure proxy check (incorrectly) succeeded. Other logs on the page would show the failure of the secure proxy check. This is a logging/display only bug (no functionality was affected). BUG=496731 Committed: https://crrev.com/3f0baabb34dd8b112b8da00cb94f206b6f7717db Cr-Commit-Position: refs/heads/master@{#333017}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sclittle CR comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
M components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc View 1 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jeremyim
PTAL!
5 years, 6 months ago (2015-06-04 16:45:23 UTC) #2
sclittle
LGTM % nit https://codereview.chromium.org/1154623008/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc (right): https://codereview.chromium.org/1154623008/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc#newcode175 components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc:175: "Succeeded", 0, net::HTTP_OK, true, true, nit: ...
5 years, 6 months ago (2015-06-05 01:25:59 UTC) #3
jeremyim
https://codereview.chromium.org/1154623008/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc (right): https://codereview.chromium.org/1154623008/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc#newcode175 components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc:175: "Succeeded", 0, net::HTTP_OK, true, true, On 2015/06/05 01:25:58, sclittle ...
5 years, 6 months ago (2015-06-05 05:22:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154623008/20001
5 years, 6 months ago (2015-06-05 05:22:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 06:11:58 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 06:12:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f0baabb34dd8b112b8da00cb94f206b6f7717db
Cr-Commit-Position: refs/heads/master@{#333017}

Powered by Google App Engine
This is Rietveld 408576698