components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc - Issue 1154623008: Fix the secure proxy check state displayed on net-internals#bandwidth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc

Issue 1154623008: Fix the secure proxy check state displayed on net-internals#bandwidth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sclittle CR comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc

index b84e0f96f79a158e7eee0ca152f1a3190890b6f3..f837eb4ba5b128b7d8c7522b3aac4820db437ab5 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc

@@ -257,8 +257,8 @@ void DataReductionProxyEventCreator::EndSecureProxyCheck(

PostBoundNetLogSecureProxyCheckEvent(

net_log, net::NetLog::TYPE_DATA_REDUCTION_PROXY_CANARY_REQUEST,

net::NetLog::PHASE_END,

- net_error == 0 ? DataReductionProxyEventStorageDelegate::CHECK_SUCCESS

- : DataReductionProxyEventStorageDelegate::CHECK_FAILED,

+ succeeded ? DataReductionProxyEventStorageDelegate::CHECK_SUCCESS

+ : DataReductionProxyEventStorageDelegate::CHECK_FAILED,

parameters_callback);

}

« no previous file with comments | « no previous file | components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc » ('j') | no next file with comments »