| Index: appengine/findit/waterfall/analyze_build_failure_pipeline.py
|
| diff --git a/appengine/findit/waterfall/analyze_build_failure_pipeline.py b/appengine/findit/waterfall/analyze_build_failure_pipeline.py
|
| index fd879f2884c4fd7995817cd634745a2a6093e92e..6ae5de1665a4ab88c8c884f4e50ca9641d023d24 100644
|
| --- a/appengine/findit/waterfall/analyze_build_failure_pipeline.py
|
| +++ b/appengine/findit/waterfall/analyze_build_failure_pipeline.py
|
| @@ -8,10 +8,11 @@ from model.wf_analysis import WfAnalysis
|
| from model import wf_analysis_status
|
| from waterfall.base_pipeline import BasePipeline
|
| from waterfall.detect_first_failure_pipeline import DetectFirstFailurePipeline
|
| +from waterfall.extract_deps_info_pipeline import ExtractDEPSInfoPipeline
|
| from waterfall.extract_signal_pipeline import ExtractSignalPipeline
|
| from waterfall.identify_culprit_pipeline import IdentifyCulpritPipeline
|
| from waterfall.pull_changelog_pipeline import PullChangelogPipeline
|
| -
|
| +
|
|
|
| class AnalyzeBuildFailurePipeline(BasePipeline):
|
|
|
| @@ -21,23 +22,23 @@ class AnalyzeBuildFailurePipeline(BasePipeline):
|
| self.master_name = master_name
|
| self.builder_name = builder_name
|
| self.build_number = build_number
|
| -
|
| +
|
| def _LogUnexpectedAborting(self, was_aborted):
|
| """Marks the WfAnalysis status as error, indicating that it was aborted.
|
| -
|
| +
|
| Args:
|
| was_aborted (bool): True if the pipeline was aborted, otherwise False.
|
| """
|
| - if was_aborted:
|
| + if was_aborted:
|
| analysis = WfAnalysis.Get(
|
| self.master_name, self.builder_name, self.build_number)
|
| if analysis: # In case the analysis is deleted manually.
|
| analysis.status = wf_analysis_status.ERROR
|
| analysis.result_status = None
|
| analysis.put()
|
| -
|
| +
|
| def finalized(self):
|
| - self._LogUnexpectedAborting(self.was_aborted)
|
| + self._LogUnexpectedAborting(self.was_aborted)
|
|
|
| def pipeline_status_path(self):
|
| """Returns an absolute path to look up the status of the pipeline."""
|
| @@ -61,5 +62,7 @@ class AnalyzeBuildFailurePipeline(BasePipeline):
|
| failure_info = yield DetectFirstFailurePipeline(
|
| master_name, builder_name, build_number)
|
| change_logs = yield PullChangelogPipeline(failure_info)
|
| + deps_info = yield ExtractDEPSInfoPipeline(failure_info, change_logs)
|
| signals = yield ExtractSignalPipeline(failure_info)
|
| - yield IdentifyCulpritPipeline(failure_info, change_logs, signals)
|
| + yield IdentifyCulpritPipeline(
|
| + failure_info, change_logs, deps_info, signals)
|
|
|