appengine/findit/common/http_client_appengine.py - Issue 1154593005: [Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/common/http_client_appengine.py

Issue 1154593005: [Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comments. Still working on unittests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/common/dependency.py ('k') | appengine/findit/waterfall/analyze_build_failure_pipeline.py » ('j') | appengine/findit/waterfall/extract_deps_info_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/common/http_client_appengine.py

diff --git a/appengine/findit/common/http_client_appengine.py b/appengine/findit/common/http_client_appengine.py

index 0581f44ddc51719b669d42d6975e234623987af8..e3a56bee8c9e4b69a69c9648271c4989648f4248 100644

--- a/appengine/findit/common/http_client_appengine.py

+++ b/appengine/findit/common/http_client_appengine.py

@@ -17,7 +17,6 @@ class HttpClientAppengine(RetryHttpClient): # pragma: no cover

result = urlfetch.fetch(url, deadline=timeout, validate_certificate=True)

if result.status_code != 200:

- logging.error('Request to %s failed with code=%d: %s',

- url, result.status_code, result.content)

+ logging.error('Request to %s resulted in %d', url, result.status_code)

return result.status_code, result.content