Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1154543003: Add strictly checked numeric types (Closed)

Created:
5 years, 7 months ago by jschuh
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, erikwright+watch_chromium.org, rickyz (no longer on Chrome)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add strictly checked numeric types StrictNumeric and strict_cast can be used for compile time detection of numeric truncation errors at API boundaries. Committed: https://crrev.com/4bf22c6d746526624b79f4c9d7b01ee5bfdbe3d3 Cr-Commit-Position: refs/heads/master@{#331725}

Patch Set 1 #

Patch Set 2 : SSizeT #

Patch Set 3 : docs #

Patch Set 4 : test fix #

Total comments: 1

Patch Set 5 : CheckedNumeric ctor and SizeT rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1 line) Patch
M base/numerics/safe_conversions.h View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
M base/numerics/safe_math.h View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 1 2 3 4 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
jschuh
PTAL
5 years, 7 months ago (2015-05-27 22:01:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154543003/40001
5 years, 7 months ago (2015-05-27 22:02:19 UTC) #4
Tom Sepez
lgtm
5 years, 7 months ago (2015-05-27 22:11:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154543003/60001
5 years, 7 months ago (2015-05-27 22:37:55 UTC) #8
rickyz (no longer on Chrome)
https://codereview.chromium.org/1154543003/diff/60001/base/numerics/safe_conversions.h File base/numerics/safe_conversions.h (right): https://codereview.chromium.org/1154543003/diff/60001/base/numerics/safe_conversions.h#newcode121 base/numerics/safe_conversions.h:121: typedef StrictNumeric<size_t> SSizeT; This name could potentially be confused ...
5 years, 7 months ago (2015-05-27 22:50:53 UTC) #9
jschuh
On 2015/05/27 22:50:53, rickyz wrote: > https://codereview.chromium.org/1154543003/diff/60001/base/numerics/safe_conversions.h > File base/numerics/safe_conversions.h (right): > > https://codereview.chromium.org/1154543003/diff/60001/base/numerics/safe_conversions.h#newcode121 > ...
5 years, 7 months ago (2015-05-27 23:04:51 UTC) #10
jschuh
On 2015/05/27 23:04:51, jschuh wrote: > On 2015/05/27 22:50:53, rickyz wrote: > > > https://codereview.chromium.org/1154543003/diff/60001/base/numerics/safe_conversions.h ...
5 years, 7 months ago (2015-05-27 23:49:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154543003/80001
5 years, 7 months ago (2015-05-27 23:50:31 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-28 02:29:33 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 02:30:20 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4bf22c6d746526624b79f4c9d7b01ee5bfdbe3d3
Cr-Commit-Position: refs/heads/master@{#331725}

Powered by Google App Engine
This is Rietveld 408576698