Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: base/numerics/safe_conversions.h

Issue 1154543003: Add strictly checked numeric types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CheckedNumeric ctor and SizeT rename Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/numerics/safe_math.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_NUMERICS_SAFE_CONVERSIONS_H_ 5 #ifndef BASE_NUMERICS_SAFE_CONVERSIONS_H_
6 #define BASE_NUMERICS_SAFE_CONVERSIONS_H_ 6 #define BASE_NUMERICS_SAFE_CONVERSIONS_H_
7 7
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // Should fail only on attempting to assign NaN to a saturated integer. 51 // Should fail only on attempting to assign NaN to a saturated integer.
52 case internal::RANGE_INVALID: 52 case internal::RANGE_INVALID:
53 CHECK(false); 53 CHECK(false);
54 return std::numeric_limits<Dst>::max(); 54 return std::numeric_limits<Dst>::max();
55 } 55 }
56 56
57 NOTREACHED(); 57 NOTREACHED();
58 return static_cast<Dst>(value); 58 return static_cast<Dst>(value);
59 } 59 }
60 60
61 // strict_cast<> is analogous to static_cast<> for numeric types, except that
62 // it will cause a compile failure if the destination type is not large enough
63 // to contain any value in the source type. It performs no runtime checking.
64 template <typename Dst, typename Src>
65 inline Dst strict_cast(Src value) {
66 static_assert(std::numeric_limits<Src>::is_specialized,
67 "Argument must be numeric.");
68 static_assert(std::numeric_limits<Dst>::is_specialized,
69 "Result must be numeric.");
70 static_assert((internal::StaticDstRangeRelationToSrcRange<Dst, Src>::value ==
71 internal::NUMERIC_RANGE_CONTAINED),
72 "The numeric conversion is out of range for this type. You "
73 "should probably use one of the following conversion "
74 "mechanisms on the value you want to pass:\n"
75 "- base::checked_cast\n"
76 "- base::saturated_cast\n"
77 "- base::CheckedNumeric");
78
79 return static_cast<Dst>(value);
80 }
81
82 // StrictNumeric implements compile time range checking between numeric types by
83 // wrapping assignment operations in a strict_cast. This class is intended to be
84 // used for function arguments and return types, to ensure the destination type
85 // can always contain the source type. This is essentially the same as enforcing
86 // -Wconversion in gcc and C4302 warnings on MSVC, but it can be applied
87 // incrementally at API boundaries, making it easier to convert code so that it
88 // compiles cleanly with truncation warnings enabled.
89 // This template should introduce no runtime overhead, but it also provides no
90 // runtime checking of any of the associated mathematical operations. Use
91 // CheckedNumeric for runtime range checks of tha actual value being assigned.
92 template <typename T>
93 class StrictNumeric {
94 public:
95 typedef T type;
96
97 StrictNumeric() : value_(0) {}
98
99 // Copy constructor.
100 template <typename Src>
101 StrictNumeric(const StrictNumeric<Src>& rhs)
102 : value_(strict_cast<T>(rhs.value_)) {}
103
104 // This is not an explicit constructor because we implicitly upgrade regular
105 // numerics to StrictNumerics to make them easier to use.
106 template <typename Src>
107 StrictNumeric(Src value)
108 : value_(strict_cast<T>(value)) {}
109
110 // The numeric cast operator basically handles all the magic.
111 template <typename Dst>
112 operator Dst() const {
113 return strict_cast<Dst>(value_);
114 }
115
116 private:
117 T value_;
118 };
119
120 // Explicitly make a shorter size_t typedef for convenience.
121 typedef StrictNumeric<size_t> SizeT;
122
61 } // namespace base 123 } // namespace base
62 124
63 #endif // BASE_NUMERICS_SAFE_CONVERSIONS_H_ 125 #endif // BASE_NUMERICS_SAFE_CONVERSIONS_H_
OLDNEW
« no previous file with comments | « no previous file | base/numerics/safe_math.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698