src/opts/Sk4px_NEON.h - Issue 1154523004: Everyone gets a namespace {}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/Sk4px_NEON.h

Issue 1154523004: Everyone gets a namespace {}. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/opts/Sk4px_NEON.h

diff --git a/src/opts/Sk4px_NEON.h b/src/opts/Sk4px_NEON.h

index f0d9b56c71194f3ec0050eeb0fdb793e5064d549..494052ceb78d7b403c6e8959e5cb483a49499171 100644

--- a/src/opts/Sk4px_NEON.h

+++ b/src/opts/Sk4px_NEON.h

@@ -5,6 +5,8 @@

* found in the LICENSE file.

+namespace { // See Sk4px.h

inline Sk4px::Sk4px(SkPMColor px) : INHERITED((uint8x16_t)vdupq_n_u32(px)) {}

inline Sk4px Sk4px::Load4(const SkPMColor px[4]) {

@@ -88,3 +90,5 @@ inline Sk4px Sk4px::zeroAlphas() const {

return Sk16b(vbicq_u8(this->fVec, (uint8x16_t)vdupq_n_u32(0xFF << SK_A32_SHIFT)));

}

+} // namespace

« no previous file with comments | « src/core/SkPMFloat.h ('k') | src/opts/Sk4px_SSE2.h » ('j') | no next file with comments »