Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1154423006: When cancelling an animation, add missing timeline-detach check. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
loyso (OOO), dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

When cancelling an animation, add missing timeline-detach check. If the animation timeline becomes unreferenced and is destructed, it detaches from its associated animations. Check that timeline detach status should cancel() be called on an animation. R=loyso,dstockwell BUG=491847 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196299

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A LayoutTests/web-animations-api/animation-timeline-detached-no-crash.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/animation/Animation.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-05-31 18:25:26 UTC) #2
loyso (OOO)
On 2015/05/31 18:25:26, sof wrote: > please take a look. Non-owner Looks Good To Me.
5 years, 6 months ago (2015-06-01 01:50:31 UTC) #3
dstockwell
lgtm
5 years, 6 months ago (2015-06-02 00:13:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154423006/20001
5 years, 6 months ago (2015-06-02 05:38:36 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 08:32:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196299

Powered by Google App Engine
This is Rietveld 408576698