Source/core/animation/Animation.cpp - Issue 1154423006: When cancelling an animation, add missing timeline-detach check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/Animation.cpp

Issue 1154423006: When cancelling an animation, add missing timeline-detach check. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/Animation.cpp

diff --git a/Source/core/animation/Animation.cpp b/Source/core/animation/Animation.cpp

index 8e1e3d64816ef2671ff01bfd0e8e3761ac3d8b53..5103120d88fef661182dd039d0726bcd241fb484 100644

--- a/Source/core/animation/Animation.cpp

+++ b/Source/core/animation/Animation.cpp

@@ -836,7 +836,8 @@ void Animation::cancel()

m_startTime = nullValue();

m_currentTimePending = false;

- InspectorInstrumentation::didCancelAnimation(timeline()->document(), this);

+ if (timeline())

+ InspectorInstrumentation::didCancelAnimation(timeline()->document(), this);

}

void Animation::beginUpdatingState()

« no previous file with comments | « LayoutTests/web-animations-api/animation-timeline-detached-no-crash.html ('k') | no next file » | no next file with comments »