Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1154323002: Use app list item shadow for app list folders. (Closed)

Created:
5 years, 7 months ago by calamity
Modified:
5 years, 6 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, tapted, sadrul, Matt Giuca, extensions-reviews_chromium.org, tfarina, chromium-apps-reviews_chromium.org, kalyank, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_arrow_keys_crash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use app list item shadow for app list folders. This CL removes the custom drawn shadow for app list folders and uses the app list item shadow to render a shadow instead. This CL also slightly tweaks the shadow values to match mocks. BUG=485393 TBR=jamescook@chromium.org Committed: https://crrev.com/da52c91d3dd2be2c6b2cf15950a3fa8ae3d03488 Cr-Commit-Position: refs/heads/master@{#333013}

Patch Set 1 #

Total comments: 2

Patch Set 2 : bump FastShowPicker version number #

Patch Set 3 : fix compile #

Patch Set 4 : fix mac compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -53 lines) Patch
M ash/shell/app_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/fast_show_pickler.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/app_list_constants.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/app_list/app_list_folder_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_item.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/app_list/app_list_item.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller_unittest.mm View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_view_item.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/demo/app_list_demo_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/folder_image.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M ui/app_list/folder_image_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/app_list/test/app_list_test_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/views/app_list_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
calamity
5 years, 7 months ago (2015-05-27 05:58:03 UTC) #2
Matt Giuca
https://codereview.chromium.org/1154323002/diff/1/chrome/browser/ui/app_list/fast_show_pickler.cc File chrome/browser/ui/app_list/fast_show_pickler.cc (right): https://codereview.chromium.org/1154323002/diff/1/chrome/browser/ui/app_list/fast_show_pickler.cc#newcode190 chrome/browser/ui/app_list/fast_show_pickler.cc:190: const int FastShowPickler::kVersion = 3; Update to 4 (because ...
5 years, 6 months ago (2015-06-03 01:16:00 UTC) #3
calamity
https://codereview.chromium.org/1154323002/diff/1/chrome/browser/ui/app_list/fast_show_pickler.cc File chrome/browser/ui/app_list/fast_show_pickler.cc (right): https://codereview.chromium.org/1154323002/diff/1/chrome/browser/ui/app_list/fast_show_pickler.cc#newcode190 chrome/browser/ui/app_list/fast_show_pickler.cc:190: const int FastShowPickler::kVersion = 3; On 2015/06/03 01:16:00, Matt ...
5 years, 6 months ago (2015-06-03 03:23:30 UTC) #4
calamity
TBRing jamescook@ for ash/ change.
5 years, 6 months ago (2015-06-03 03:25:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154323002/20001
5 years, 6 months ago (2015-06-03 03:29:52 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/31874)
5 years, 6 months ago (2015-06-03 04:44:23 UTC) #9
Matt Giuca
lgtm
5 years, 6 months ago (2015-06-04 01:07:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154323002/40001
5 years, 6 months ago (2015-06-04 01:35:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/72979)
5 years, 6 months ago (2015-06-04 02:17:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154323002/60001
5 years, 6 months ago (2015-06-05 04:29:18 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-05 06:05:47 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 06:07:55 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/da52c91d3dd2be2c6b2cf15950a3fa8ae3d03488
Cr-Commit-Position: refs/heads/master@{#333013}

Powered by Google App Engine
This is Rietveld 408576698