components/nacl.gyp - Issue 1154313003: Non-SFI mode: Implement test launcher for nacl_helper_nonsfi_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl.gyp

Issue 1154313003: Non-SFI mode: Implement test launcher for nacl_helper_nonsfi_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small clean up for code review. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/test/launcher/test_launcher.h ('K') | « build/all.gyp ('k') | components/nacl/loader/nonsfi/test_launcher_nacl_nonsfi.cc » ('j') | components/nacl/loader/nonsfi/test_launcher_nacl_nonsfi.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl.gyp

diff --git a/components/nacl.gyp b/components/nacl.gyp

index 9c8e2b3de15f370f0555fe04fd4230402f002ab3..8fb901161ef400b87f19b430c22d7f1e605cf41c 100644

--- a/components/nacl.gyp

+++ b/components/nacl.gyp

@@ -449,6 +449,21 @@

}],

+ ['disable_nacl==0 and disable_nacl_untrusted==0 and enable_nacl_nonsfi_test==1', {

+ 'targets': [

+ {

+ 'target_name': 'nacl_helper_nonsfi_unittests',

+ 'type': '<(gtest_target_type)',

+ 'sources': [

+ 'nacl/loader/nonsfi/test_launcher_nacl_nonsfi.cc',

+ ],

+ 'dependencies': [

+ '../base/base.gyp:test_support_base',

+ 'nacl_nonsfi.gyp:nacl_helper_nonsfi_unittests_main',

+ ],

+ },

+ ],

+ }],

'targets': [

{