Non-SFI mode: Implement test launcher for nacl_helper_nonsfi_unittests

base/test/launcher/test_launcher.h

Index: base/test/launcher/test_launcher.h
diff --git a/base/test/launcher/test_launcher.h b/base/test/launcher/test_launcher.h
index 544df63c6390e2435b7fa011310451cf884dd901..734c5b631d0020446f20029d73ea46d671a24c97 100644
--- a/base/test/launcher/test_launcher.h
+++ b/base/test/launcher/test_launcher.h
@@ -115,6 +115,12 @@ class TestLauncher {
   // Called when a test has finished running.
   void OnTestFinished(const TestResult& result);
 
+  // If enabled, the launcher will not remove the --gtest_output flag passed
+  // to the child processes.
+  void set_use_child_gtest_output(bool value) {

[Paweł Hajdan Jr., 2015/05/29 13:48:20]

This looks like a layering violation. Why is it needed?

[hidehiko, 2015/05/29 14:00:47]

Because nacl_helper_nonsfi_unittests_main still uses vanilla gtest library and
gtest_main, as building the test-support-library with PNaCl toolchain looks not
that straightforward due to the limited support of the toolchain, and also it
depends on some third party library, such as libxml.
So, subprocess uses xml output of vanilla gtest library with
--gtest_output=xml:PATH_TO_XML_OUTPUT, rather than linking
base::XmlUnitTestResultPrinter. Fortunately, these are compatible.

[Paweł Hajdan Jr., 2015/06/01 10:56:59]

Is it possible to extract a smaller build target containing just the
functionality needed for nacl test launcher?

Alternatively, what is the specific problem with nacl toolchain?
AFAICT that dependency comes from base/test/gtest_xml_util.cc but we only use it
for reading and not writing.

It should be possible to extract just the writing parts and only compile that
with nacl toolchain.
There are subtle differences, e.g. we've added x-teststart.

Still, this accessor just doesn't belong here. I think above recommendations
should make it unnecessary - please let me know if there's something I missed.

[hidehiko, 2015/06/02 08:12:17]

Ok, thank you for suggestion.
Then, how about the latest PS?

+    use_child_gtest_output_ = value;
+  }
+
  private:
   bool Init() WARN_UNUSED_RESULT;
 
@@ -149,6 +155,8 @@ class TestLauncher {
 
   TestLauncherDelegate* launcher_delegate_;
 
+  bool use_child_gtest_output_;
+
   // Support for outer sharding, just like gtest does.
   int32 total_shards_;  // Total number of outer shards, at least one.
   int32 shard_index_;   // Index of shard the launcher is to run.