Non-SFI mode: Implement test launcher for nacl_helper_nonsfi_unittests

base/test/launcher/test_launcher.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
 #define BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 97 matching lines @@
   // on the same thread this method was called.
   void LaunchChildGTestProcess(const CommandLine& command_line,
                                const std::string& wrapper,
                                base::TimeDelta timeout,
                                int flags,
                                const LaunchChildGTestProcessCallback& callback);
 
   // Called when a test has finished running.
   void OnTestFinished(const TestResult& result);
 
+  // If enabled, the launcher will not remove the --gtest_output flag passed
+  // to the child processes.
+  void set_use_child_gtest_output(bool value) {

[Paweł Hajdan Jr., 2015/05/29 13:48:20]

This looks like a layering violation. Why is it needed?

[hidehiko, 2015/05/29 14:00:47]

Because nacl_helper_nonsfi_unittests_main still uses vanilla gtest library and
gtest_main, as building the test-support-library with PNaCl toolchain looks not
that straightforward due to the limited support of the toolchain, and also it
depends on some third party library, such as libxml.
So, subprocess uses xml output of vanilla gtest library with
--gtest_output=xml:PATH_TO_XML_OUTPUT, rather than linking
base::XmlUnitTestResultPrinter. Fortunately, these are compatible.

[Paweł Hajdan Jr., 2015/06/01 10:56:59]

Is it possible to extract a smaller build target containing just the
functionality needed for nacl test launcher?

Alternatively, what is the specific problem with nacl toolchain?
AFAICT that dependency comes from base/test/gtest_xml_util.cc but we only use it
for reading and not writing.

It should be possible to extract just the writing parts and only compile that
with nacl toolchain.
There are subtle differences, e.g. we've added x-teststart.

Still, this accessor just doesn't belong here. I think above recommendations
should make it unnecessary - please let me know if there's something I missed.

[hidehiko, 2015/06/02 08:12:17]

Ok, thank you for suggestion.
Then, how about the latest PS?

+    use_child_gtest_output_ = value;
+  }
+
  private:
   bool Init() WARN_UNUSED_RESULT;
 
   // Runs all tests in current iteration. Uses callbacks to communicate success.
   void RunTests();
 
   void RunTestIteration();
 
   // Saves test results summary as JSON if requested from command line.
   void MaybeSaveSummaryAsJSON();
@@ skipping 14 matching lines @@
 
   // Make sure we don't accidentally call the wrong methods e.g. on the worker
   // pool thread. With lots of callbacks used this is non-trivial.
   // Should be the first member so that it's destroyed last: when destroying
   // other members, especially the worker pool, we may check the code is running
   // on the correct thread.
   ThreadChecker thread_checker_;
 
   TestLauncherDelegate* launcher_delegate_;
 
+  bool use_child_gtest_output_;
+
   // Support for outer sharding, just like gtest does.
   int32 total_shards_;  // Total number of outer shards, at least one.
   int32 shard_index_;   // Index of shard the launcher is to run.
 
   int cycles_;  // Number of remaining test itreations, or -1 for infinite.
 
   // Test filters (empty means no filter).
   std::vector<std::string> positive_test_filter_;
   std::vector<std::string> negative_test_filter_;
 
@@ skipping 39 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(TestLauncher);
 };
 
 // Extract part from |full_output| that applies to |result|.
 std::string GetTestOutputSnippet(const TestResult& result,
                                  const std::string& full_output);
 
 }  // namespace base
 
 #endif  // BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_