Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 11543002: Add a switch to enable compositing for scrollable frames. (Closed)

Created:
8 years ago by Xianzhu
Modified:
8 years ago
Reviewers:
jamesr, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add a switch to enable compositing for scrollable frames. '--enable-accelerated-scrollable-frames' Enabled by default on Android. By the way, changed '--enable-accelerated-compositing-for-overflow-scroll' to '--enable-accelerated-overflow-scroll' to make it consistent with the other existing switches. (The existing patterns of names: switch: --enable-accelerated-... or --disable-accelerated-... switch C++ name: kEnableAccelerated... or kDisableAccelerated... WebPreferences field: accelerated_compositing_for_..._enabled WebSettings setter: setAcceleratedCompositingFor...Enabled) BUG=163022 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Xianzhu
8 years ago (2012-12-11 18:15:24 UTC) #1
jam
lgtm
8 years ago (2012-12-11 20:32:04 UTC) #2
Xianzhu
@jamesr, this CL still needs an approval from you (as an owner of webkit/).
8 years ago (2012-12-12 01:36:19 UTC) #3
jamesr
webkit lgtm
8 years ago (2012-12-12 01:37:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/11543002/1
8 years ago (2012-12-12 01:40:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chromeos_unittests, ...
8 years ago (2012-12-12 02:50:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/11543002/1
8 years ago (2012-12-12 17:06:43 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years ago (2012-12-12 19:34:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/11543002/1
8 years ago (2012-12-12 19:42:41 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-12 19:45:18 UTC) #10
Message was sent while issue was closed.
Change committed as 172642

Powered by Google App Engine
This is Rietveld 408576698