Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1154273002: Revert of Extract re-usable InitializeMediaFoundation() (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, ananta
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extract re-usable InitializeMediaFoundation() (patchset #3 id:40001 of https://codereview.chromium.org/1149203002/) Reason for revert: Broke compile on the Win GN bots: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/2154 Original issue's description: > Extract re-usable InitializeMediaFoundation() > > Allow media::InitializeMediaFoundation() to be used by any Media > Foundation client code. This benefits existing Chromium code as well as any > Chromium-based browser that adds its own code calling out to Media Foundation. > > There are two side effects for DXVAVideoDecodeAccelerator: > > - MFStartup() and MFShutdown() are now called once during the lifetime of the > GPU process rather than per each accelerator instance. > > - MFStartup() is now called with the MFSTARTUP_LITE flag, which according to > MSDN doesn't initialize the sockets library. > > TEST=media_unittests > > Committed: https://crrev.com/c0ab75a86447bc23d45ff7086b2375e2cd83c205 > Cr-Commit-Position: refs/heads/master@{#331446} TBR=sandersd@chromium.org,wdzierzanowski@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/13c59839d6142eb81308bdda8d8da25b05137a28 Cr-Commit-Position: refs/heads/master@{#331448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -81 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D media/base/win/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D media/base/win/mf_initializer.h View 1 chunk +0 lines, -18 lines 0 comments Download
D media/base/win/mf_initializer.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/capture/win/video_capture_device_factory_win.cc View 5 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
Created Revert of Extract re-usable InitializeMediaFoundation()
5 years, 6 months ago (2015-05-26 22:12:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154273002/1
5 years, 6 months ago (2015-05-26 22:13:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-26 22:14:38 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-05-26 22:15:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13c59839d6142eb81308bdda8d8da25b05137a28
Cr-Commit-Position: refs/heads/master@{#331448}

Powered by Google App Engine
This is Rietveld 408576698