Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1154243006: Disable deterministic Javascript for Swiffy benchmark pages (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable deterministic Javascript for Swiffy benchmark pages Swiffy updates animations based on the current time (Date.now()), so we shouldn't override that function to return dummy values. BUG=493357 Committed: https://crrev.com/42de8af2a0a3786f72a9ec477d4c765f3fbf9a57 Cr-Commit-Position: refs/heads/master@{#333026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/page_sets/tough_ad_cases.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Sami
5 years, 6 months ago (2015-06-04 14:25:47 UTC) #2
petrcermak
LGTM :-) Thanks, Petr
5 years, 6 months ago (2015-06-04 15:04:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154243006/1
5 years, 6 months ago (2015-06-04 15:09:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/64172)
5 years, 6 months ago (2015-06-04 16:12:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154243006/1
5 years, 6 months ago (2015-06-05 09:37:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 09:59:43 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 10:00:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42de8af2a0a3786f72a9ec477d4c765f3fbf9a57
Cr-Commit-Position: refs/heads/master@{#333026}

Powered by Google App Engine
This is Rietveld 408576698