tools/perf/page_sets/tough_ad_cases.py - Issue 1154243006: Disable deterministic Javascript for Swiffy benchmark pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/tough_ad_cases.py

Issue 1154243006: Disable deterministic Javascript for Swiffy benchmark pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/tough_ad_cases.py

diff --git a/tools/perf/page_sets/tough_ad_cases.py b/tools/perf/page_sets/tough_ad_cases.py

index a691515b1c26420f868ed7ff1370a8293b7d89c7..3706bfe5f66ef6df531203b4627988e460c15bef 100644

--- a/tools/perf/page_sets/tough_ad_cases.py

+++ b/tools/perf/page_sets/tough_ad_cases.py

@@ -9,7 +9,8 @@ from telemetry.page import page_set as page_set_module

class SwiffyPage(page_module.Page):

def __init__(self, url, page_set):

- super(SwiffyPage, self).__init__(url=url, page_set=page_set)

+ super(SwiffyPage, self).__init__(url=url, page_set=page_set,

+ make_javascript_deterministic=False)

def RunNavigateSteps(self, action_runner):

super(SwiffyPage, self).RunNavigateSteps(action_runner)

« no previous file with comments | « no previous file | no next file » | no next file with comments »