Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: sky/engine/core/painting/Rect.dart

Issue 1154213005: Add operator==, hashCode, and toString for Rect and Point dart classes. (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sky/engine/core/painting/Point.dart ('K') | « sky/engine/core/painting/Point.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/painting/Rect.dart
diff --git a/sky/engine/core/painting/Rect.dart b/sky/engine/core/painting/Rect.dart
index cb2afec7d773e004e1ec77a276ea82dce7d6df77..64b086ada90d568e3b708fffeecefe1b9ec805f2 100644
--- a/sky/engine/core/painting/Rect.dart
+++ b/sky/engine/core/painting/Rect.dart
@@ -14,4 +14,19 @@ class Rect {
void setLTRB(double left, double top, double right, double bottom) {
sethladd 2015/05/27 22:19:49 Dart has named constructors. You could do: Rect.L
Matt Perry 2015/05/28 17:05:54 Done.
_value = new Float32List.fromList([left, top, right, bottom]);
}
+
+ bool operator ==(other) {
+ if (!(other is Rect)) return false;
+ for (var i = 0; i < 4; ++i) {
+ if (_value[i] != other._value[i])
+ return false;
+ }
+ return true;
+ }
+ int get hashCode {
+ return _value.fold(373, (value, item) => (37 * value + item.hashCode));
+ }
+ String toString() {
sethladd 2015/05/27 22:19:49 consider using => here
Matt Perry 2015/05/28 17:05:54 Done.
+ return "Rect.LTRB($left, $top, $right, $bottom)";
+ }
}
« sky/engine/core/painting/Point.dart ('K') | « sky/engine/core/painting/Point.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698