Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 part of dart.sky; | 5 part of dart.sky; |
| 6 | 6 |
| 7 class Rect { | 7 class Rect { |
| 8 Float32List _value; | 8 Float32List _value; |
| 9 double get left => _value[0]; | 9 double get left => _value[0]; |
| 10 double get top => _value[1]; | 10 double get top => _value[1]; |
| 11 double get right => _value[2]; | 11 double get right => _value[2]; |
| 12 double get bottom => _value[3]; | 12 double get bottom => _value[3]; |
| 13 | 13 |
| 14 void setLTRB(double left, double top, double right, double bottom) { | 14 void setLTRB(double left, double top, double right, double bottom) { |
|
sethladd
2015/05/27 22:19:49
Dart has named constructors. You could do:
Rect.L
Matt Perry
2015/05/28 17:05:54
Done.
| |
| 15 _value = new Float32List.fromList([left, top, right, bottom]); | 15 _value = new Float32List.fromList([left, top, right, bottom]); |
| 16 } | 16 } |
| 17 | |
| 18 bool operator ==(other) { | |
| 19 if (!(other is Rect)) return false; | |
| 20 for (var i = 0; i < 4; ++i) { | |
| 21 if (_value[i] != other._value[i]) | |
| 22 return false; | |
| 23 } | |
| 24 return true; | |
| 25 } | |
| 26 int get hashCode { | |
| 27 return _value.fold(373, (value, item) => (37 * value + item.hashCode)); | |
| 28 } | |
| 29 String toString() { | |
|
sethladd
2015/05/27 22:19:49
consider using => here
Matt Perry
2015/05/28 17:05:54
Done.
| |
| 30 return "Rect.LTRB($left, $top, $right, $bottom)"; | |
| 31 } | |
| 17 } | 32 } |
| OLD | NEW |