Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1154213002: Update libc++/libc++abi build flags. (Closed)

Created:
5 years, 7 months ago by earthdok
Modified:
5 years, 7 months ago
Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update libc++/libc++abi build flags. - Mysterious -pthread warning explained. - Remove libc++abi link flags - it's a static library. - Add some missing flags, sort list items. BUG=none R=jochen@chromium.org Committed: a85661f97e83c620a8a1d0255829eb7a674e12cc

Patch Set 1 #

Patch Set 2 : add -fPIC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M third_party/libc++/libc++.gyp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/libc++abi/libc++abi.gyp View 1 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
earthdok
5 years, 7 months ago (2015-05-26 15:14:10 UTC) #2
earthdok
5 years, 7 months ago (2015-05-26 15:14:10 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-26 15:51:30 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 7 months ago (2015-05-26 15:54:02 UTC) #7
earthdok
On 2015/05/26 15:51:30, jochen wrote: > lgtm Updated: Added -fPIC, another missing flag. I assume ...
5 years, 7 months ago (2015-05-26 17:45:48 UTC) #8
jochen (gone - plz use gerrit)
Committed patchset #2 (id:20001) manually as a85661f97e83c620a8a1d0255829eb7a674e12cc (presubmit successful).
5 years, 7 months ago (2015-05-27 07:37:40 UTC) #9
earthdok
5 years, 7 months ago (2015-05-27 14:59:45 UTC) #10
Message was sent while issue was closed.
On 2015/05/27 07:37:40, jochen wrote:
> Committed patchset #2 (id:20001) manually as
> a85661f97e83c620a8a1d0255829eb7a674e12cc (presubmit successful).

Thanks!

Powered by Google App Engine
This is Rietveld 408576698