Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/libc++/libc++.gyp

Issue 1154213002: Update libc++/libc++abi build flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/buildtools.git@master
Patch Set: add -fPIC Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libc++abi/libc++abi.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libc++/libc++.gyp
diff --git a/third_party/libc++/libc++.gyp b/third_party/libc++/libc++.gyp
index c6011de4498b6cdd4bf2a53be0c7ae1e7847aa37..7422d10fc206e2abff91376a31aaf3a651d4f3f0 100644
--- a/third_party/libc++/libc++.gyp
+++ b/third_party/libc++/libc++.gyp
@@ -88,8 +88,10 @@
'../libc++abi/trunk/include',
],
'cflags': [
+ '-fPIC',
'-fstrict-aliasing',
'-nostdinc++',
+ '-pthread',
'-std=c++11',
],
'cflags_cc!': [
@@ -103,14 +105,14 @@
'-nodefaultlibs',
],
'ldflags!': [
- # This somehow causes a warning from clang about an unused compilation
- # option. Use '-lpthread' instead.
- # TODO(earthdok): find out what's causing the warning.
+ # -nodefaultlibs turns -pthread into a no-op, causing an unused argument
+ # warning. Explicitly link with -lpthread instead.
'-pthread',
],
'libraries': [
'-lc',
'-lgcc_s',
+ '-lm',
'-lpthread',
'-lrt',
],
« no previous file with comments | « no previous file | third_party/libc++abi/libc++abi.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698