Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1154163012: Fix edge-line artifacts issue on Mali (Closed)

Created:
5 years, 6 months ago by Joel.Liang
Modified:
5 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix edge-line artifacts issue on Mali Some GMs show edge-line artifacts on Mali at the bottom/right of the canvas. Change the 'rtAdjustment' uniform precision from 'midiump' to 'highp' if the GPU vendor is ARM. NOTE: Vertex Shader should have default 'highp' precision, but now we explicit declared some uniform/attribute precision as 'midiump'. This patch should fix these issues: Issue 3693: Some GMs produce random artifacts on Mali in MSAA4 https://code.google.com/p/skia/issues/detail?id=3693 Issue 3685: srcmode GM has top/right line artifacts on Mali T604 in MSAA4 https://code.google.com/p/skia/issues/detail?id=3685 BUG=skia: Committed: https://skia.googlesource.com/skia/+/d18bb23667d11db4779c13253a7e0cd90bf7a57f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jvanverth1
Just tried this patch with Chrome -- it doesn't appear to address issue 3853.
5 years, 6 months ago (2015-06-02 15:57:14 UTC) #2
jvanverth1
Just tried this patch with Chrome -- it doesn't appear to address issue 3853.
5 years, 6 months ago (2015-06-02 15:57:17 UTC) #3
Joel.Liang
On 2015/06/02 15:57:17, jvanverth1 wrote: > Just tried this patch with Chrome -- it doesn't ...
5 years, 6 months ago (2015-06-03 07:09:23 UTC) #4
bsalomon
lgtm
5 years, 6 months ago (2015-06-04 13:46:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154163012/1
5 years, 6 months ago (2015-06-04 13:47:06 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 13:52:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d18bb23667d11db4779c13253a7e0cd90bf7a57f

Powered by Google App Engine
This is Rietveld 408576698