Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: runtime/vm/coverage_test.cc

Issue 1154163004: Libraries have uris not urls. Scripts have uris not names. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/get_object_rpc_test.dart ('k') | runtime/vm/debugger_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/coverage_test.cc
diff --git a/runtime/vm/coverage_test.cc b/runtime/vm/coverage_test.cc
index 2301d3a5d8108666357407011c023a7dc69b77b9..8e53c7b9dc06e8ad7210ae1891f69298143d5fb9 100644
--- a/runtime/vm/coverage_test.cc
+++ b/runtime/vm/coverage_test.cc
@@ -51,7 +51,7 @@ TEST_CASE(Coverage_Empty) {
OS::SNPrint(buf, sizeof(buf),
"{\"source\":\"test-lib\",\"script\":{\"type\":\"@Script\","
"\"id\":\"libraries\\/%" Pd "\\/scripts\\/test-lib\","
- "\"name\":\"test-lib\","
+ "\"uri\":\"test-lib\","
"\"kind\":\"script\"},\"hits\":[]}", lib.index());
EXPECT_SUBSTRING(buf, js.ToCString());
}
@@ -88,7 +88,7 @@ TEST_CASE(Coverage_MainWithClass) {
OS::SNPrint(buf, sizeof(buf),
"{\"source\":\"test-lib\",\"script\":{\"type\":\"@Script\","
"\"id\":\"libraries\\/%" Pd "\\/scripts\\/test-lib\","
- "\"name\":\"test-lib\","
+ "\"uri\":\"test-lib\","
"\"kind\":\"script\"},\"hits\":[3,1,5,4,6,3]}", lib.index());
EXPECT_SUBSTRING(buf, js.ToCString());
@@ -96,7 +96,7 @@ TEST_CASE(Coverage_MainWithClass) {
OS::SNPrint(buf, sizeof(buf),
"{\"source\":\"test-lib\",\"script\":{\"type\":\"@Script\","
"\"id\":\"libraries\\/%" Pd "\\/scripts\\/test-lib\","
- "\"name\":\"test-lib\","
+ "\"uri\":\"test-lib\","
"\"kind\":\"script\"},\"hits\":[10,1,11,1]}", lib.index());
EXPECT_SUBSTRING(buf, js.ToCString());
}
@@ -134,7 +134,7 @@ TEST_CASE(Coverage_FilterFunction) {
OS::SNPrint(buf, sizeof(buf),
"{\"source\":\"test-lib\",\"script\":{\"type\":\"@Script\","
"\"id\":\"libraries\\/%" Pd "\\/scripts\\/test-lib\","
- "\"name\":\"test-lib\","
+ "\"uri\":\"test-lib\","
"\"kind\":\"script\"},\"hits\":[6,0]}", lib.index());
EXPECT_SUBSTRING(buf, js.ToCString());
}
« no previous file with comments | « runtime/observatory/tests/service/get_object_rpc_test.dart ('k') | runtime/vm/debugger_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698