Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1154103005: Refactor lexical home object binding (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
wingo, adamk
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor lexical home object binding Before this we had 3 super related lexical bindings that got injected into method bodies: .home_object, .this_function, and new.target. With this change we get rid of the .home_object one in favor of using .this_function[home_object_symbol] which allows some simplifications throughout the code base. BUG=v8:3768 LOG=N R=adamk@chromium.org, wingo@igalia.com Committed: https://crrev.com/345fa142a9fca4b468417350ac26f61101d626e8 Cr-Commit-Position: refs/heads/master@{#28802}

Patch Set 1 #

Total comments: 1

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -325 lines) Patch
M src/arm/full-codegen-arm.cc View 1 12 chunks +10 lines, -27 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 12 chunks +10 lines, -28 lines 0 comments Download
M src/ast.h View 6 chunks +10 lines, -37 lines 0 comments Download
M src/ast-numbering.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast-value-factory.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 12 chunks +10 lines, -28 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 12 chunks +10 lines, -28 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 12 chunks +10 lines, -28 lines 0 comments Download
M src/parser.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 12 chunks +10 lines, -28 lines 0 comments Download
M src/scopes.h View 2 chunks +3 lines, -13 lines 0 comments Download
M src/scopes.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 12 chunks +10 lines, -28 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 12 chunks +10 lines, -30 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 1 10 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-03 21:35:04 UTC) #2
adamk
Looks fine except for what's going on in ast-value-factory. I don't recall the decision around ...
5 years, 6 months ago (2015-06-03 22:39:12 UTC) #3
adamk
I should say this lgtm as-is, if we decide to do something different in AstValueFactory ...
5 years, 6 months ago (2015-06-03 22:40:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154103005/1
5 years, 6 months ago (2015-06-03 23:17:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1023)
5 years, 6 months ago (2015-06-03 23:19:27 UTC) #8
arv (Not doing code reviews)
git rebase
5 years, 6 months ago (2015-06-04 15:25:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154103005/20001
5 years, 6 months ago (2015-06-04 15:46:29 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-04 16:22:34 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 16:22:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/345fa142a9fca4b468417350ac26f61101d626e8
Cr-Commit-Position: refs/heads/master@{#28802}

Powered by Google App Engine
This is Rietveld 408576698