Refactor lexical home object binding

src/ast-value-factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 149 matching lines @@
 
 
 void AstValue::Internalize(Isolate* isolate) {
   switch (type_) {
     case STRING:
       DCHECK(string_ != NULL);
       // Strings are already internalized.
       DCHECK(!string_->string().is_null());
       break;
     case SYMBOL:
-      DCHECK_EQ(0, strcmp(symbol_name_, "iterator_symbol"));
-      value_ = isolate->factory()->iterator_symbol();
+      if (symbol_name_[0] == 'i') {

[adamk, 2015/06/03 22:39:12]

This is not going to scale well, I wonder if we should just have two
AstValue::Type enums (ITERATOR_SYMBOL and HOME_OBJECT_SYMBOL).

+        DCHECK_EQ(0, strcmp(symbol_name_, "iterator_symbol"));
+        value_ = isolate->factory()->iterator_symbol();
+      } else {
+        DCHECK_EQ(0, strcmp(symbol_name_, "home_object_symbol"));
+        value_ = isolate->factory()->home_object_symbol();
+      }
       break;
     case NUMBER:
       value_ = isolate->factory()->NewNumber(number_, TENURED);
       break;
     case SMI:
       value_ = handle(Smi::FromInt(smi_), isolate);
       break;
     case BOOLEAN:
       if (bool_) {
         value_ = isolate->factory()->true_value();
@@ skipping 191 matching lines @@
   const AstRawString* lhs = static_cast<AstRawString*>(a);
   const AstRawString* rhs = static_cast<AstRawString*>(b);
   if (lhs->is_one_byte() != rhs->is_one_byte()) return false;
   if (lhs->hash() != rhs->hash()) return false;
   int len = lhs->byte_length();
   if (rhs->byte_length() != len) return false;
   return memcmp(lhs->raw_data(), rhs->raw_data(), len) == 0;
 }
 }  // namespace internal
 }  // namespace v8