Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/form_structure.h

Index: chrome/browser/autofill/form_structure.h
diff --git a/chrome/browser/autofill/form_structure.h b/chrome/browser/autofill/form_structure.h
index 45cf2bbcc365e51c6ed7d834dd741a4181d81d3c..1542f980d29ad87eae864fa92387e5246e36f405 100644
--- a/chrome/browser/autofill/form_structure.h
+++ b/chrome/browser/autofill/form_structure.h
@@ -124,6 +124,10 @@ class FormStructure {
   void ParseFieldTypesFromAutocompleteAttributes(bool* found_types,
                                                  bool* found_sections);
 
+  bool IsStartOfAutofillableFlow() const;
+
+  bool IsInAutofillableFlow() const;

[Ilya Sherman, 2013/01/15 06:31:52]

nit: Please add documentation for these methods.

[Raman Kakilate, 2013/01/15 23:02:33]

Done.

+
   const AutofillField* field(size_t index) const;
   AutofillField* field(size_t index);
   size_t field_count() const;
@@ -208,6 +212,14 @@ class FormStructure {
   // GET or POST.
   RequestMethod method_;
 
+  // Page number of the autofill flow, this form belongs to. If this form
+  // doesn't belong to any autofill flow, it is set to -1.

[Ilya Sherman, 2013/01/15 06:31:52]

What if the received XML specifies that the page number is -1?  Where does
error-checking take place?

[Ilya Sherman, 2013/01/15 06:31:52]

Is this zero-indexed or 1-indexed?

[Raman Kakilate, 2013/01/15 23:02:33]

Zero indexed. Added in the comment.

[Raman Kakilate, 2013/01/15 23:02:33]

Updated implementation of IsStartOfAutofillableFlow() to also check for
(total_pages_ > 0). 

If server returns -1, it would be treated as outside autofillable flow.

+  int current_page_number_;
+
+  // Total number of pages in the autofill flow. If this form doesn't belong
+  // to any autofill flow, it is set to -1.
+  int total_pages_;
+
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;