Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/form_structure.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 #define CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 106 matching lines @@
   // Classifies each field in |fields_| based upon its |autocomplete| attribute,
   // if the attribute is available.  The association is stored into the field's
   // |heuristic_type|.
   // Fills |found_types| with |true| if the attribute is available and neither
   // empty nor set to the special values "on" or "off" for at least one field.
   // Fills |found_sections| with |true| if the attribute specifies a section for
   // at least one field.
   void ParseFieldTypesFromAutocompleteAttributes(bool* found_types,
                                                  bool* found_sections);
 
+  bool IsStartOfAutofillableFlow() const;
+
+  bool IsInAutofillableFlow() const;

[Ilya Sherman, 2013/01/15 06:31:52]

nit: Please add documentation for these methods.

[Raman Kakilate, 2013/01/15 23:02:33]

Done.

+
   const AutofillField* field(size_t index) const;
   AutofillField* field(size_t index);
   size_t field_count() const;
 
   // Returns the number of fields that are able to be autofilled.
   size_t autofill_count() const { return autofill_count_; }
 
   // Used for iterating over the fields.
   std::vector<AutofillField*>::const_iterator begin() const {
     return fields_.begin();
@@ skipping 64 matching lines @@
   // to the stored upload rates.
   UploadRequired upload_required_;
 
   // The server experiment corresponding to the server types returned for this
   // form.
   std::string server_experiment_id_;
 
   // GET or POST.
   RequestMethod method_;
 
+  // Page number of the autofill flow, this form belongs to. If this form
+  // doesn't belong to any autofill flow, it is set to -1.

[Ilya Sherman, 2013/01/15 06:31:52]

What if the received XML specifies that the page number is -1?  Where does
error-checking take place?

[Ilya Sherman, 2013/01/15 06:31:52]

Is this zero-indexed or 1-indexed?

[Raman Kakilate, 2013/01/15 23:02:33]

Zero indexed. Added in the comment.

[Raman Kakilate, 2013/01/15 23:02:33]

Updated implementation of IsStartOfAutofillableFlow() to also check for
(total_pages_ > 0). 

If server returns -1, it would be treated as outside autofillable flow.

+  int current_page_number_;
+
+  // Total number of pages in the autofill flow. If this form doesn't belong
+  // to any autofill flow, it is set to -1.
+  int total_pages_;
+
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_