Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_flow_util.h

Index: chrome/browser/autofill/autofill_flow_util.h
diff --git a/chrome/browser/autofill/autofill_flow_util.h b/chrome/browser/autofill/autofill_flow_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..29e09d539768549c7e6a00c586ccb133448b42f0
--- /dev/null
+++ b/chrome/browser/autofill/autofill_flow_util.h
@@ -0,0 +1,22 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Ilya Sherman, 2013/01/15 06:31:52]

nit: 2013, since this is a new file.  (Applies to all new files in this CL.)

[Raman Kakilate, 2013/01/15 23:02:33]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_UTIL_H_
+#define CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_UTIL_H_
+
+#include <string>
+
+struct FormData;
+struct FormFieldData;
+
+namespace autofill {
+
+FormFieldData BuildField(const std::string& autocomplete_attribute);
+
+FormData BuildAutofillFlowFormData();

[Ilya Sherman, 2013/01/15 06:31:52]

Why are these exposed in their own header file?  These seem like functions that
could easily be in an anonymous namespace in the one file that uses them.

[Ilya Sherman, 2013/01/15 06:31:52]

If you do keep these functions here, please add documentation.

[Raman Kakilate, 2013/01/15 23:02:33]

Done.

[Raman Kakilate, 2013/01/15 23:02:33]

You asked me move out of infobars as they are complex by themselves.

[Ilya Sherman, 2013/01/15 23:24:46]

The infobar code is still calling this, so you've just moved the definitions of
the functions out.  What I meant with my previous was that the infobar code
shouldn't need to worry about this at all -- I'd expect this to instead be
within the AutocheckoutManager implementation.

[Raman Kakilate, 2013/01/16 19:20:12]

created AutocheckoutManager and moved the functions there.

+
+}  // namespace autofill
+
+#endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_UTIL_H_
+