chrome/browser/autofill/autofill_flow_util.h - Issue 11539003: Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

Side by Side Diff: chrome/browser/autofill/autofill_flow_util.h

Issue 11539003: Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressed Albert's comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/autofill/autofill_flow_infobar_delegate.cc ('K') | « chrome/browser/autofill/autofill_flow_infobar_delegate.cc ('k') | chrome/browser/autofill/autofill_flow_util.cc » ('j') | chrome/browser/autofill/autofill_flow_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	Ilya Sherman 2013/01/15 06:31:52 nit: 2013, since this is a new file. (Applies to nit: 2013, since this is a new file. (Applies to all new files in this CL.) Raman Kakilate 2013/01/15 23:02:33 Done. Show quoted text On 2013/01/15 06:31:52, Ilya Sherman wrote: > nit: 2013, since this is a new file. (Applies to all new files in this CL.) Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_UTIL_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_UTIL_H_

	7

	8 #include <string>

	9

	10 struct FormData;

	11 struct FormFieldData;

	12

	13 namespace autofill {

	14

	15 FormFieldData BuildField(const std::string& autocomplete_attribute);

	16

	17 FormData BuildAutofillFlowFormData();
	Ilya Sherman 2013/01/15 06:31:52 Why are these exposed in their own header file? T Why are these exposed in their own header file? These seem like functions that could easily be in an anonymous namespace in the one file that uses them. Ilya Sherman 2013/01/15 06:31:52 If you do keep these functions here, please add do If you do keep these functions here, please add documentation. Raman Kakilate 2013/01/15 23:02:33 Done. Show quoted text On 2013/01/15 06:31:52, Ilya Sherman wrote: > If you do keep these functions here, please add documentation. Done. Raman Kakilate 2013/01/15 23:02:33 You asked me move out of infobars as they are comp Show quoted text On 2013/01/15 06:31:52, Ilya Sherman wrote: > Why are these exposed in their own header file? These seem like functions that > could easily be in an anonymous namespace in the one file that uses them. You asked me move out of infobars as they are complex by themselves. Ilya Sherman 2013/01/15 23:24:46 The infobar code is still calling this, so you've Show quoted text On 2013/01/15 23:02:33, Raman Kakilate wrote: > On 2013/01/15 06:31:52, Ilya Sherman wrote: > > Why are these exposed in their own header file? These seem like functions > that > > could easily be in an anonymous namespace in the one file that uses them. > > You asked me move out of infobars as they are complex by themselves. The infobar code is still calling this, so you've just moved the definitions of the functions out. What I meant with my previous was that the infobar code shouldn't need to worry about this at all -- I'd expect this to instead be within the AutocheckoutManager implementation. Raman Kakilate 2013/01/16 19:20:12 created AutocheckoutManager and moved the function Show quoted text On 2013/01/15 23:24:46, Ilya Sherman wrote: > On 2013/01/15 23:02:33, Raman Kakilate wrote: > > On 2013/01/15 06:31:52, Ilya Sherman wrote: > > > Why are these exposed in their own header file? These seem like functions > > that > > > could easily be in an anonymous namespace in the one file that uses them. > > > > You asked me move out of infobars as they are complex by themselves. > > The infobar code is still calling this, so you've just moved the definitions of > the functions out. What I meant with my previous was that the infobar code > shouldn't need to worry about this at all -- I'd expect this to instead be > within the AutocheckoutManager implementation. created AutocheckoutManager and moved the functions there.
	18

	19 } // namespace autofill

	20

	21 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_UTIL_H_

	22

OLD	NEW