Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_xml_parser.cc

Index: chrome/browser/autofill/autofill_xml_parser.cc
diff --git a/chrome/browser/autofill/autofill_xml_parser.cc b/chrome/browser/autofill/autofill_xml_parser.cc
index 92a1ede91c0f94dbc96794d4060b2c51af488145..c73d5e82a02270a1f26973d2b3ee7218a9f7514a 100644
--- a/chrome/browser/autofill/autofill_xml_parser.cc
+++ b/chrome/browser/autofill/autofill_xml_parser.cc
@@ -33,6 +33,7 @@ AutofillQueryXmlParser::AutofillQueryXmlParser(
     std::string* experiment_id)
     : field_types_(field_types),
       upload_required_(upload_required),
+      page_no_(0), total_pages_(0),
       experiment_id_(experiment_id) {
   DCHECK(upload_required_);
   DCHECK(experiment_id_);
@@ -89,6 +90,19 @@ void AutofillQueryXmlParser::StartElement(buzz::XmlParseContext* context,
 
     // Record this field type.
     field_types_->push_back(field_type);
+  } else if (element.compare("wallet_data") == 0) {

[Ilya Sherman, 2012/12/13 02:29:23]

"wallet_data" does not seem like an appropriate name for this field.  This data
is not in any way specific to Wallet.

[Raman Kakilate, 2012/12/13 21:34:34]

wallet_data is tag that is already added on autofill servers. True, that the
concept of filling flow which spans multiple pages is not tied to wallet, but it
is where we are starting.

[Ilya Sherman, 2012/12/13 23:23:18]

Please rename the tag in the server code.  Baking "wallet" into the name is not
appropriate.

[Raman Kakilate, 2013/01/10 00:54:40]

Done.

+    // |attrs| is a NULL-terminated list of (attribute, value) pairs.
+    while (*attrs) {
+      buzz::QName attribute_qname = context->ResolveQName(*attrs, true);
+      ++attrs;
+      const std::string& attribute_name = attribute_qname.LocalPart();
+      if (attribute_name.compare("page_no") == 0) {
+        page_no_ = GetIntValue(context, *attrs);
+      } else if (attribute_name.compare("total_pages") == 0) {
+        total_pages_ = GetIntValue(context, *attrs);
+      }
+      ++attrs;
+    }
   }
 }