Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_xml_parser.h

Index: chrome/browser/autofill/autofill_xml_parser.h
diff --git a/chrome/browser/autofill/autofill_xml_parser.h b/chrome/browser/autofill/autofill_xml_parser.h
index da3d5bf661a3ebf33a33af49635ad6940cd55cdc..16ae0d08996e443d031ec8a1cd8f3c8bbf47ed97 100644
--- a/chrome/browser/autofill/autofill_xml_parser.h
+++ b/chrome/browser/autofill/autofill_xml_parser.h
@@ -70,6 +70,10 @@ class AutofillQueryXmlParser : public AutofillXmlParser {
                          UploadRequired* upload_required,
                          std::string* experiment_id);
 
+  int GetPageNo() { return page_no_; }

[Ilya Sherman, 2012/12/13 02:29:23]

nit: Please spell out "number".  This method should be named "page_number()";
the variable should be named "page_number_"

[Raman Kakilate, 2012/12/13 21:34:34]

Done.

+
+  int GetTotalPages() { return total_pages_; }

[Ilya Sherman, 2012/12/13 02:29:23]

nit: This method should be named total_pages()

[Raman Kakilate, 2012/12/13 21:34:34]

Done.

+
  private:
   // A callback for the beginning of a new <element>, called by Expat.
   // |context| is a parsing context used to resolve element/attribute names.
@@ -92,6 +96,12 @@ class AutofillQueryXmlParser : public AutofillXmlParser {
   // form is submitted.
   UploadRequired* upload_required_;
 
+  // Page number of present page in multipage autofill flow.

[Ilya Sherman, 2012/12/13 02:29:23]

Why is the XML server responsible for keeping track of which page this is? 
Shouldn't it always be the first page?

[Raman Kakilate, 2012/12/13 21:34:34]

Idea is show autofill_dialog_controller UI on the first page and gather all the
data required for the flow. and on subsequent pages, we should just fill the
page and navigate.

we would have to identify
- start of the flow
- being inside the flow and
- the last step of the flow. 

All of that information can be inferred using page_number_ and total_pages_

[Ilya Sherman, 2012/12/13 23:23:18]

That all makes sense.  What I don't understand is why the server would ever send
down data for any page other than the first.  I'd expect that when the user
navigates to the first page in the flow, the server simply sends down data for
that page as well as all subsequent pages in the flow.  This allows us to avoid
the overhead of making a new connection to the server on each page load.  What
am I missing?

[Raman Kakilate, 2013/01/10 00:54:40]

Server sending down data for all the possible flows at once is an option we
haven't considered much. We could definitely do it as optimization (will involve
changes in both chrome and autofill server).

+  int page_no_;
+
+  // Total number of pages in multipage autofill flow.
+  int total_pages_;
+
   // The server experiment to which this query response belongs.
   // For the default server implementation, this is empty.
   std::string* experiment_id_;