Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Unified Diff: chrome/browser/content_settings/permission_context_base.h

Issue 1153873003: Add way for PermissionContext to be automatically restricted to secure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@midi_permission_sysex
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_context_base.h
diff --git a/chrome/browser/content_settings/permission_context_base.h b/chrome/browser/content_settings/permission_context_base.h
index 0f24beedf833c7f999bbd32fd8cf63e6820db64d..65b71ca5794012d8b4b39700378b1dc054996cb2 100644
--- a/chrome/browser/content_settings/permission_context_base.h
+++ b/chrome/browser/content_settings/permission_context_base.h
@@ -123,6 +123,9 @@ class PermissionContextBase : public KeyedService {
const GURL& embedding_origin,
ContentSetting content_setting);
+ // Whether the permission should be restricted to secured origins.
+ virtual bool RestrictToSecureOrigins() const = 0;
Miguel Garcia 2015/05/26 09:34:33 can you add a default implementation? I guess defa
ddorwin 2015/05/26 17:31:31 Should this be IsRestrcited...?
mlamouri (slow - plz ping) 2015/05/29 14:35:15 I did not on purpose so implementations will have
+
private:
// Called when a bubble is no longer used so it can be cleaned up.
void CleanUpBubble(const PermissionRequestID& id);

Powered by Google App Engine
This is Rietveld 408576698