Add way for PermissionContext to be automatically restricted to secure origins.

chrome/browser/content_settings/permission_context_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_BASE_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_BASE_H_
 
 #include "base/callback.h"
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/memory/ref_counted.h"
@@ skipping 27 matching lines @@
 //   - Define your new permission in the ContentSettingsType enum.
 //   - Create a class that inherits from PermissionContextBase and passes the
 //     new permission.
 //   - Inherit from PermissionInfobarDelegate and implement
 //     |GetMessageText|
 //   - Edit the PermissionBubbleRequestImpl methods to add the new text for
 //     the bubble.
 //   - Hit several asserts for the missing plumbing and fix them :)
 // After this you can override several other methods to customize behavior,
 // in particular it is advised to override UpdateTabContext in order to manage
 // the permission from the omnibox.

[Miguel Garcia, 2015/05/26 09:34:33]

perhaps add here that we need to decide if the new permission works for
http/https via RestrictToSecureOrigins

[mlamouri (slow - plz ping), 2015/05/29 14:35:14]

Done.

 // See midi_permission_context.h/cc or push_permission_context.cc/h for some
 // examples.
 
 class PermissionContextBase : public KeyedService {
  public:
   PermissionContextBase(Profile* profile,
                         const ContentSettingsType permission_type);
   ~PermissionContextBase() override;
 
   // The renderer is requesting permission to push messages.
@@ skipping 57 matching lines @@
   // Returns the profile associated with this permission context.
   Profile* profile() const;
 
   // Store the decided permission as a content setting.
   // virtual since the permission might be stored with different restrictions
   // (for example for desktop notifications).
   virtual void UpdateContentSetting(const GURL& requesting_origin,
                                     const GURL& embedding_origin,
                                     ContentSetting content_setting);
 
+  // Whether the permission should be restricted to secured origins.
+  virtual bool RestrictToSecureOrigins() const = 0;

[Miguel Garcia, 2015/05/26 09:34:33]

can you add a default implementation? I guess default to true.

[ddorwin, 2015/05/26 17:31:31]

Should this be IsRestrcited...?

[mlamouri (slow - plz ping), 2015/05/29 14:35:15]

I did not on purpose so implementations will have to think about it.

On 2015/05/26 at 17:31:31, ddorwin wrote:
Yes.

+
  private:
   // Called when a bubble is no longer used so it can be cleaned up.
   void CleanUpBubble(const PermissionRequestID& id);
 
   Profile* profile_;
   const ContentSettingsType permission_type_;
   scoped_ptr<PermissionQueueController> permission_queue_controller_;
   base::ScopedPtrHashMap<std::string, scoped_ptr<PermissionBubbleRequest>>
       pending_bubbles_;
 
   // Must be the last member, to ensure that it will be
   // destroyed first, which will invalidate weak pointers
   base::WeakPtrFactory<PermissionContextBase> weak_factory_;
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_BASE_H_