Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents Base URL: https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/background_printing_manager.cc ('k') | chrome/browser/task_manager/task_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_preview_dialog_controller.cc
diff --git a/chrome/browser/printing/print_preview_dialog_controller.cc b/chrome/browser/printing/print_preview_dialog_controller.cc
index 8d1ff323b34b1a93da58825286dfdbd45314218c..01f6e90801adcd419190dbc405c8c71537072dd2 100644
--- a/chrome/browser/printing/print_preview_dialog_controller.cc
+++ b/chrome/browser/printing/print_preview_dialog_controller.cc
@@ -178,7 +178,9 @@ WebContents* PrintPreviewDialogController::GetOrCreatePreviewDialog(
return CreatePrintPreviewDialog(initiator);
// Show the initiator holding the existing preview dialog.
- initiator->GetDelegate()->ActivateContents(initiator);
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ initiator->GetDelegate()->ActivateContents(initiator,
+ false /* user_gesture */);
return preview_dialog;
}
« no previous file with comments | « chrome/browser/printing/background_printing_manager.cc ('k') | chrome/browser/task_manager/task_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698