Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(40)

Issue 1153763005: scheduler: Allow timer task to be nested (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Allow timer task to be nested Blink's current shared timer mechanism, which we are trying to replace, allows timers to execute in nested message loops, but only if the nested message loop itself was not initiated by a timer. We believe this limitation is a historical relic which was originally introduced to prevent multiple invocations of the same timer[1]. When the shared timer is replaced by indivially posted tasks, the underlying scheduler will ensure that each task is only executed once. Therefore it should be safe to lift this restriction. [1] https://trac.webkit.org/changeset/12774 BUG=463143, 416362, 480522 Committed: https://crrev.com/022f550d73963aa4ce245aeaa0515504d89b2e24 Cr-Commit-Position: refs/heads/master@{#331133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/scheduler/child/web_scheduler_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sami
PTAL. As a background we realized that the timer heap's nesting behavior is a little ...
4 years, 4 months ago (2015-05-22 15:20:04 UTC) #2
alex clarke (OOO till 29th)
lgtm
4 years, 4 months ago (2015-05-22 15:27:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153763005/1
4 years, 4 months ago (2015-05-22 16:12:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2015-05-22 17:14:56 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2015-05-22 17:15:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/022f550d73963aa4ce245aeaa0515504d89b2e24
Cr-Commit-Position: refs/heads/master@{#331133}

Powered by Google App Engine
This is Rietveld 408576698