media/video/capture/fake_video_capture_device.h - Issue 1153713006: FakeVideoCaptureDevice: Regulate framerate without drifting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/fake_video_capture_device.h

Issue 1153713006: FakeVideoCaptureDevice: Regulate framerate without drifting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mcasas@ comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/video/capture/fake_video_capture_device.h

diff --git a/media/video/capture/fake_video_capture_device.h b/media/video/capture/fake_video_capture_device.h

index f4a19f9edb9c2c6611aa8d66cc15094f905ead7f..a2ade64fa573d47a64ec8d4da621ede4181c741c 100644

--- a/media/video/capture/fake_video_capture_device.h

+++ b/media/video/capture/fake_video_capture_device.h

@@ -41,9 +41,13 @@ class MEDIA_EXPORT FakeVideoCaptureDevice : public VideoCaptureDevice {

private:

static const int kFakeCapturePeriodMs = 50;

- void CaptureUsingOwnBuffers();

- void CaptureUsingClientBuffers(VideoPixelFormat pixel_format);

- void BeepAndScheduleNextCapture(const base::Closure& next_capture);

+ void CaptureUsingOwnBuffers(const base::TimeTicks& expected_execution_time);

mcasas 2015/06/09 19:41:16 Please read [1] l.24-26, IOW in this case don't pa

magjed_chromium 2015/06/10 11:19:55 Done.

+ void CaptureUsingClientBuffers(

+ VideoPixelFormat pixel_format,

+ const base::TimeTicks& expected_execution_time);

+ void BeepAndScheduleNextCapture(

+ const base::TimeTicks& expected_execution_time,

+ const base::Callback<void(const base::TimeTicks&)>& next_capture);

// |thread_checker_| is used to check that all methods are called in the

// correct thread that owns the object.

« no previous file with comments | « no previous file | media/video/capture/fake_video_capture_device.cc » ('j') | media/video/capture/fake_video_capture_device.cc » ('J')