FakeVideoCaptureDevice: Regulate framerate without drifting

media/video/capture/fake_video_capture_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of a fake VideoCaptureDevice class. Used for testing other
 // video capture classes when no real hardware is available.
 
 #ifndef MEDIA_VIDEO_CAPTURE_FAKE_VIDEO_CAPTURE_DEVICE_H_
 #define MEDIA_VIDEO_CAPTURE_FAKE_VIDEO_CAPTURE_DEVICE_H_
 
@@ skipping 23 matching lines @@
   ~FakeVideoCaptureDevice() override;
 
   // VideoCaptureDevice implementation.
   void AllocateAndStart(const VideoCaptureParams& params,
                         scoped_ptr<Client> client) override;
   void StopAndDeAllocate() override;
 
  private:
   static const int kFakeCapturePeriodMs = 50;
 
-  void CaptureUsingOwnBuffers();
-  void CaptureUsingClientBuffers(VideoPixelFormat pixel_format);
-  void BeepAndScheduleNextCapture(const base::Closure& next_capture);
+  void CaptureUsingOwnBuffers(const base::TimeTicks& expected_execution_time);

[mcasas, 2015/06/09 19:41:16]

Please read [1] l.24-26, IOW in this case don't pass
by reference. I find it counterintuitive, but well...

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/base/time/time.h&s...

[magjed_chromium, 2015/06/10 11:19:55]

Done.

+  void CaptureUsingClientBuffers(
+      VideoPixelFormat pixel_format,
+      const base::TimeTicks& expected_execution_time);
+  void BeepAndScheduleNextCapture(
+      const base::TimeTicks& expected_execution_time,
+      const base::Callback<void(const base::TimeTicks&)>& next_capture);
 
   // |thread_checker_| is used to check that all methods are called in the
   // correct thread that owns the object.
   base::ThreadChecker thread_checker_;
 
   const FakeVideoCaptureDeviceType device_type_;
 
   scoped_ptr<VideoCaptureDevice::Client> client_;
   // |fake_frame_| is used for capturing on Own Buffers.
   scoped_ptr<uint8[]> fake_frame_;
   int frame_count_;
   VideoCaptureFormat capture_format_;
 
   // FakeVideoCaptureDevice post tasks to itself for frame construction and
   // needs to deal with asynchronous StopAndDeallocate().
   base::WeakPtrFactory<FakeVideoCaptureDevice> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeVideoCaptureDevice);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_FAKE_VIDEO_CAPTURE_DEVICE_H_