Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1153663004: [Autofill] Remove (most) support for variants in chrome/browser (Closed)

Created:
5 years, 6 months ago by Evan Stade
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Remove (most) support for variants in chrome/browser removes variants tests, removes support from AutofillDialogController BUG=493856 Committed: https://crrev.com/535bd61c9dbcd922aec91485954521f9e3422771 Cr-Commit-Position: refs/heads/master@{#332244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -140 lines) Patch
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 3 chunks +3 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
5 years, 6 months ago (2015-06-01 16:58:05 UTC) #2
please use gerrit instead
lgtm
5 years, 6 months ago (2015-06-01 17:19:23 UTC) #4
please use gerrit instead
You need an OWNERS LG from someone in https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/sync/OWNERS for the change in chrome/browser/sync/profile_sync_service_autofill_unittest.cc.
5 years, 6 months ago (2015-06-01 17:20:39 UTC) #6
Evan Stade
+zea for chrome/browser/sync/
5 years, 6 months ago (2015-06-01 18:09:49 UTC) #8
Nicolas Zea
sync LGTM Just double checking, variants that are synced in from older clients will simply ...
5 years, 6 months ago (2015-06-01 18:19:45 UTC) #9
Evan Stade
On 2015/06/01 18:19:45, Nicolas Zea wrote: > sync LGTM > > Just double checking, variants ...
5 years, 6 months ago (2015-06-01 18:20:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153663004/1
5 years, 6 months ago (2015-06-01 18:22:14 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 19:42:32 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 19:43:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/535bd61c9dbcd922aec91485954521f9e3422771
Cr-Commit-Position: refs/heads/master@{#332244}

Powered by Google App Engine
This is Rietveld 408576698