chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 1153663004: [Autofill] Remove (most) support for variants in chrome/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 1153663004: [Autofill] Remove (most) support for variants in chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index e1a4d9b16554add43aa440bc83e1bdf086a48e3c..652953a0976cdc4209e7ee84fa1a441600955c42 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -2396,9 +2396,7 @@ void AutofillDialogControllerImpl::DidAcceptSuggestion(

GetManager()->GetCreditCardByGUID(sid.guid)));

} else {

wrapper.reset(new AutofillProfileWrapper(

- GetManager()->GetProfileByGUID(sid.guid),

- AutofillType(popup_input_type),

- sid.variant));

+ GetManager()->GetProfileByGUID(sid.guid)));

}

} else {

wrapper.reset(new I18nAddressDataWrapper(

@@ -3056,8 +3054,6 @@ void AutofillDialogControllerImpl::SuggestionsUpdated() {

continue;

}

- // Don't add variants for addresses: name is part of credit card and

- // we'll just ignore email and phone number variants.

suggested_shipping_.AddKeyedItem(profile.guid(), labels[i]);

suggested_shipping_.SetEnabled(

profile.guid(),