Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: DefineOwnProperty() doesn't work in V8InjectedScriptHost::setNonEnumPropertyMethodCustom Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

index 711660a221e95b51290102b292feee5fc94e3a2f..c0f4d1f3beb4de0f35565fb2f1a56d4449019df9 100644

--- a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

@@ -565,6 +565,7 @@ void V8InjectedScriptHost::setNonEnumPropertyMethodCustom(const v8::FunctionCall

return;

v8::Local<v8::Object> object = info[0].As<v8::Object>();

+ // TODO(bashi): Use DefineOwnProperty() if possible.

jochen (gone - plz use gerrit) 2015/06/03 10:55:17 what exception does this throw?

bashi 2015/06/05 01:10:27 Nevermind; this custom bindings has gone. https://

object->ForceSet(info.GetIsolate()->GetCurrentContext(), info[1], info[2], v8::DontEnum);

}

« Source/bindings/core/v8/WindowProxy.cpp ('K') | « Source/bindings/core/v8/WindowProxy.cpp ('k') | Source/bindings/modules/v8/V8BindingForModules.cpp » ('j') | no next file with comments »