Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149383005: DevTools: remove InjectedScriptHost.idl, implement the binding without generator (Closed)

Created:
5 years, 6 months ago by yurys
Modified:
5 years, 6 months ago
Reviewers:
alph, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove InjectedScriptHost.idl, implement the binding without generator All but one methods on InjectedScriptHost have custom implementation. Also this file is going to be extracted into a standalone v8 inspector and should not depend on the blink bindings generator. BUG=466631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -849 lines) Patch
D Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +0 lines, -611 lines 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp View 3 chunks +8 lines, -51 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A Source/bindings/core/v8/inspector/V8InjectedScriptHost.h View 1 chunk +54 lines, -0 lines 0 comments Download
A + Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp View 27 chunks +148 lines, -57 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 5 chunks +7 lines, -3 lines 0 comments Download
D Source/core/inspector/InjectedScriptHost.idl View 1 chunk +0 lines, -69 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.h View 3 chunks +0 lines, -17 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.cpp View 2 chunks +0 lines, -25 lines 0 comments Download
M Source/core/inspector/injected_script_externs.js View 2 chunks +172 lines, -0 lines 0 comments Download
M Source/devtools/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yurys
5 years, 6 months ago (2015-06-04 14:03:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149383005/1
5 years, 6 months ago (2015-06-04 14:04:28 UTC) #4
sergeyv
lgtm
5 years, 6 months ago (2015-06-04 14:34:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149383005/1
5 years, 6 months ago (2015-06-04 14:36:15 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 16:51:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196513

Powered by Google App Engine
This is Rietveld 408576698