Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/custom/V8MessageEventCustom.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

index 7e68cec02f23f4089edd95a4562b1f4ba5efc856..08826a18b2b67a5d420d01d0d2f65d42f0684f97 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

@@ -33,6 +33,7 @@ template<class CallbackInfo>

static void TestInterfaceNamedConstructorForceSetAttributeOnThis(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

{

ASSERT(info.This()->IsObject());

+ // TODO(bashi): Consider using CreateDataProperty() instead of ForceSet().

v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCurrentContext(), name, v8Value);

jochen (gone - plz use gerrit) 2015/06/02 16:14:48 why can't this use CreateDataProperty already now?

bashi 2015/06/03 00:16:37 Done.

}