bindings: Use CreateDataProperty() instead of ForceSet()

Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
 
 #include "config.h"
 #include "V8TestInterfaceNamedConstructor.h"
 
 #include "bindings/core/v8/ExceptionState.h"
@@ skipping 15 matching lines @@
 // For details, see the comment of DEFINE_WRAPPERTYPEINFO in
 // bindings/core/v8/ScriptWrappable.h.
 const WrapperTypeInfo& TestInterfaceNamedConstructor::s_wrapperTypeInfo = V8TestInterfaceNamedConstructor::wrapperTypeInfo;
 
 namespace TestInterfaceNamedConstructorV8Internal {
 
 template<class CallbackInfo>
 static void TestInterfaceNamedConstructorForceSetAttributeOnThis(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)
 {
     ASSERT(info.This()->IsObject());
+    // TODO(bashi): Consider using CreateDataProperty() instead of ForceSet().
     v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCurrentContext(), name, v8Value);

[jochen (gone - plz use gerrit), 2015/06/02 16:14:48]

why can't this use CreateDataProperty already now?

[bashi, 2015/06/03 00:16:37]

Done.

 }
 
 static void TestInterfaceNamedConstructorConstructorAttributeSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
     do {
         v8::Local<v8::Value> data = info.Data();
         ASSERT(data->IsExternal());
         V8PerContextData* perContextData = V8PerContextData::from(info.Holder()->CreationContext());
         if (!perContextData)
@@ skipping 162 matching lines @@
 {
     scriptWrappable->toImpl<TestInterfaceNamedConstructor>()->ref();
 }
 
 void V8TestInterfaceNamedConstructor::derefObject(ScriptWrappable* scriptWrappable)
 {
     scriptWrappable->toImpl<TestInterfaceNamedConstructor>()->deref();
 }
 
 } // namespace blink