Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix uninitialized error Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
diff --git a/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp b/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
index 75c29fe933be4ad86661ddc95d5b950b77116114..1e757ca6dfd9a90c1a92caa7ab5f53a053598828 100644
--- a/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
+++ b/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
@@ -54,9 +54,8 @@ v8::Local<v8::Value> toV8(const TestPermissiveDictionary& impl, v8::Local<v8::Ob
bool toV8TestPermissiveDictionary(const TestPermissiveDictionary& impl, v8::Local<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
{
- // TODO(bashi): Use ForceSet() instead of Set(). http://crbug.com/476720
if (impl.hasBooleanMember()) {
- if (!v8CallBoolean(dictionary->Set(isolate->GetCurrentContext(), v8String(isolate, "booleanMember"), v8Boolean(impl.booleanMember(), isolate))))
+ if (!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentContext(), v8String(isolate, "booleanMember"), v8Boolean(impl.booleanMember(), isolate))))
return false;
}
« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/bindings/tests/results/core/V8TestTypedefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698