Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix uninitialized error Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestPermissiveDictionary.h" 8 #include "V8TestPermissiveDictionary.h"
9 9
10 #include "bindings/core/v8/ExceptionState.h" 10 #include "bindings/core/v8/ExceptionState.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 v8::Local<v8::Value> toV8(const TestPermissiveDictionary& impl, v8::Local<v8::Ob ject> creationContext, v8::Isolate* isolate) 47 v8::Local<v8::Value> toV8(const TestPermissiveDictionary& impl, v8::Local<v8::Ob ject> creationContext, v8::Isolate* isolate)
48 { 48 {
49 v8::Local<v8::Object> v8Object = v8::Object::New(isolate); 49 v8::Local<v8::Object> v8Object = v8::Object::New(isolate);
50 if (!toV8TestPermissiveDictionary(impl, v8Object, creationContext, isolate)) 50 if (!toV8TestPermissiveDictionary(impl, v8Object, creationContext, isolate))
51 return v8::Local<v8::Value>(); 51 return v8::Local<v8::Value>();
52 return v8Object; 52 return v8Object;
53 } 53 }
54 54
55 bool toV8TestPermissiveDictionary(const TestPermissiveDictionary& impl, v8::Loca l<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* is olate) 55 bool toV8TestPermissiveDictionary(const TestPermissiveDictionary& impl, v8::Loca l<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* is olate)
56 { 56 {
57 // TODO(bashi): Use ForceSet() instead of Set(). http://crbug.com/476720
58 if (impl.hasBooleanMember()) { 57 if (impl.hasBooleanMember()) {
59 if (!v8CallBoolean(dictionary->Set(isolate->GetCurrentContext(), v8Strin g(isolate, "booleanMember"), v8Boolean(impl.booleanMember(), isolate)))) 58 if (!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentCon text(), v8String(isolate, "booleanMember"), v8Boolean(impl.booleanMember(), isol ate))))
60 return false; 59 return false;
61 } 60 }
62 61
63 return true; 62 return true;
64 } 63 }
65 64
66 TestPermissiveDictionary NativeValueTraits<TestPermissiveDictionary>::nativeValu e(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionSta te) 65 TestPermissiveDictionary NativeValueTraits<TestPermissiveDictionary>::nativeValu e(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionSta te)
67 { 66 {
68 TestPermissiveDictionary impl; 67 TestPermissiveDictionary impl;
69 V8TestPermissiveDictionary::toImpl(isolate, value, impl, exceptionState); 68 V8TestPermissiveDictionary::toImpl(isolate, value, impl, exceptionState);
70 return impl; 69 return impl;
71 } 70 }
72 71
73 } // namespace blink 72 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/bindings/tests/results/core/V8TestTypedefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698