Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153483002: [turbofan] Enable deoptimization for non-asm.js TurboFan code. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable deoptimization for non-asm.js TurboFan code. Replace the --turbo-deoptimization flag with --turbo-asm-deoptimization and enable deoptimization for non-asm.js TurboFan code unconditionally. R=jarin@chromium.org Committed: https://crrev.com/c9a49da0d8d0cfb8f6f2b204156ad19eabebd86f Cr-Commit-Position: refs/heads/master@{#28543}

Patch Set 1 #

Patch Set 2 : Fix invalid optimized code registration for asm.js code. #

Patch Set 3 : REBASE #

Patch Set 4 : Don't use the HasDeoptimizationData() predicate, it's wrong. #

Total comments: 2

Patch Set 5 : Fix Michis comment. REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -137 lines) Patch
M src/compiler.cc View 1 2 3 4 4 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 1 2 3 4 chunks +10 lines, -11 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M src/frames.cc View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 2 3 4 2 chunks +7 lines, -20 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 31 chunks +1 line, -30 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 26 chunks +0 lines, -26 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 16 chunks +0 lines, -19 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-21 09:29:41 UTC) #1
Benedikt Meurer
Hey Jaro, Say goodbye to --turbo-deoptimization. :-) Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-21 09:30:37 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1153483002/diff/60001/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/1153483002/diff/60001/src/compiler.cc#newcode508 src/compiler.cc:508: if (!info()->shared_info()->asm_function() || nit: Can we use "info()->is_deoptimization_enabled()" ...
5 years, 7 months ago (2015-05-21 11:05:07 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1153483002/diff/60001/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/1153483002/diff/60001/src/compiler.cc#newcode508 src/compiler.cc:508: if (!info()->shared_info()->asm_function() || Nice catch, thanks!
5 years, 7 months ago (2015-05-21 11:07:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153483002/80001
5 years, 7 months ago (2015-05-21 11:09:19 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-21 11:33:51 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 11:34:03 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/c9a49da0d8d0cfb8f6f2b204156ad19eabebd86f
Cr-Commit-Position: refs/heads/master@{#28543}

Powered by Google App Engine
This is Rietveld 408576698