src/debug.cc - Issue 1153483002: [turbofan] Enable deoptimization for non-asm.js TurboFan code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 1153483002: [turbofan] Enable deoptimization for non-asm.js TurboFan code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Michis comment. REBASE Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index df8eab79eb983f61608a54e4fdd1a34ffe414b46..b5e81c55cb239042c63d7147b2b3c56ba4ba7f9e 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -1882,7 +1882,8 @@ void Debug::PrepareForBreakPoints() {

if (kind == Code::OPTIMIZED_FUNCTION) {

// Optimized code can only get here if DeoptimizeAll did not

// deoptimize turbo fan code.

- DCHECK(!FLAG_turbo_deoptimization);

+ DCHECK(!FLAG_turbo_asm_deoptimization);

+ DCHECK(function->shared()->asm_function());

DCHECK(function->code()->is_turbofanned());

function->ReplaceCode(fallback);

}

« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »